Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Prover CLI): status batch --verbose #1899

Merged
merged 126 commits into from
May 15, 2024
Merged

Conversation

ColoCarletti
Copy link
Contributor

@ColoCarletti ColoCarletti commented May 9, 2024

This pull request introduces a new flag, verbose, to the status batch command. Retrieves detailed information about the prover jobs for each aggregation round, and circuit for a specific batch number.

To run the command:

zk f cargo run -- status batch -n [1..] --verbose

This command accepts any number of L1 batch numbers.

Example output:

$ cargo run --release -- status batch -n 1 --verbose

== Batch 1 Status ==

-- Aggregation Round 0 --
> Basic Witness Generator: Successful ✅
v Prover Jobs: In Progress ⌛️
   > VM: Successful ✅
   > DecommitmentsFilter: Successful ✅
   > Decommiter: Successful ✅
   > LogDemultiplexer: Successful ✅
   > KeccakPrecompile: In Progress ⌛️
     - Total jobs: 60
     - Successful: 4
     - In Progress: 1
     - Queued: 55
     - Failed: 0
   > RamValidation: Successful ✅
   > StorageFilter: Queued 📥
   > StorageApplicator: Successful ✅
   > EventsRevertsFilter: Queued 📥
   > L1MessagesRevertsFilter: Queued 📥
   > L1MessagesHasher: Queued 📥
   > EIP4844Repack: Queued 📥

-- Aggregation Round 1 --
v Leaf Witness Generator: In Progress ⌛️
   > VM: Successful ✅
   > DecommitmentsFilter: Successful ✅
   > Decommiter: Successful ✅
   > LogDemultiplexer: Successful ✅
   > KeccakPrecompile: Waiting for Proof ⏱️
   > RamValidation: Successful ✅
   > StorageFilter: Waiting for Proof ⏱️
   > StorageApplicator: Successful ✅
   > EventsRevertsFilter: Waiting for Proof ⏱️
   > L1MessagesRevertsFilter: Waiting for Proof ⏱️
   > L1MessagesHasher: Waiting for Proof ⏱️
   > EIP4844Repack: Waiting for Proof ⏱️
> Prover Jobs: Successful ✅

-- Aggregation Round 2 --
v Node Witness Generator: In Progress ⌛️
   > VM: Successful ✅
   > DecommitmentsFilter: Successful ✅
   > Decommiter: Successful ✅
   > LogDemultiplexer: Successful ✅
   > KeccakPrecompile: Waiting for Proof ⏱️
   > RamValidation: Successful ✅
   > StorageFilter: Waiting for Proof ⏱️
   > StorageApplicator: Successful ✅
   > EventsRevertsFilter: Waiting for Proof ⏱️
   > L1MessagesRevertsFilter: Waiting for Proof ⏱️
   > L1MessagesHasher: Waiting for Proof ⏱️
   > EIP4844Repack: Waiting for Proof ⏱️
> Prover Jobs: Successful ✅

-- Aggregation Round 3 --
 > Recursion Tip: Waiting for Proof ⏱️

-- Aggregation Round 4 --
 > Scheduler: Waiting for Proof ⏱️

-- Compression --
 > Compressor: Jobs not found 🚫

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.

Artemka374
Artemka374 previously approved these changes May 14, 2024
Copy link
Contributor

@Artemka374 Artemka374 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, but agree with comments above

@Artemka374 Artemka374 added this pull request to the merge queue May 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 14, 2024
@Oppen
Copy link
Contributor

Oppen commented May 14, 2024

@Artemka374 there's been an issue with the merge queue. This job failed: https://github.com/matter-labs/zksync-era/actions/runs/9082768899/job/24959975241

$ yarn workspace zk build
$ tsc
Done in 2.55s.
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  3 4096M    3  148M    0     0   150M      0  0:00:27 --:--:--  0:00:27  150M
  7 4096M    7  312M    0     0   156M      0  0:00:26  0:00:01  0:00:25  156M
 11 4096M   11  476M    0     0   159M      0  0:00:25  0:00:02  0:00:23  159M
 14 4096M   14  612M    0     0   153M      0  0:00:26  0:00:03  0:00:23  153M
 16 4096M   16  692M    0     0   153M      0  0:00:26  0:00:04  0:00:22  153M
curl: (56) Recv failure: Connection reset by peer

@ilitteri
Copy link
Contributor

@Artemka374 there's been an issue with the merge queue. This job failed: https://github.com/matter-labs/zksync-era/actions/runs/9082768899/job/24959975241

$ yarn workspace zk build
$ tsc
Done in 2.55s.
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  3 4096M    3  148M    0     0   150M      0  0:00:27 --:--:--  0:00:27  150M
  7 4096M    7  312M    0     0   156M      0  0:00:26  0:00:01  0:00:25  156M
 11 4096M   11  476M    0     0   159M      0  0:00:25  0:00:02  0:00:23  159M
 14 4096M   14  612M    0     0   153M      0  0:00:26  0:00:03  0:00:23  153M
 16 4096M   16  692M    0     0   153M      0  0:00:26  0:00:04  0:00:22  153M
curl: (56) Recv failure: Connection reset by peer

Yep, we'll probably need to re-queue until it passes

@Artemka374 Artemka374 added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit cf80184 May 15, 2024
50 checks passed
@Artemka374 Artemka374 deleted the prover_cli_status_verbose branch May 15, 2024 10:18
RomanBrodetski pushed a commit that referenced this pull request May 17, 2024
🤖 I have created a release *beep* *boop*
---


##
[24.3.0](core-v24.2.0...core-v24.3.0)
(2024-05-16)


### Features

* Added support for making EN a (non-leader) consensus validator
(BFT-426)
([#1905](#1905))
([9973629](9973629))
* **configs:** Extract secrets to an additional config
([#1956](#1956))
([bab4d65](bab4d65))
* **en:** Fetch L1 batch root hashes from main node
([#1923](#1923))
([72a3571](72a3571))
* **eth-client:** Generalize RPC client
([#1898](#1898))
([a4e099f](a4e099f))
* **Prover CLI:** `requeue` cmd
([#1719](#1719))
([f722df7](f722df7))
* **Prover CLI:** `status batch --verbose`
([#1899](#1899))
([cf80184](cf80184))
* **pruning:** Vacuum freeze started daily
([#1929](#1929))
([5c85e9f](5c85e9f))
* Remove metrics crate
([#1902](#1902))
([5f7bda7](5f7bda7))
* **state-keeper:** Parallel l2 block sealing
([#1801](#1801))
([9b06dd8](9b06dd8))
* tee_verifier_input_producer
([#1860](#1860))
([fea7f16](fea7f16))
* **vm-runner:** implement output handler for VM runner
([#1856](#1856))
([1e4aeb5](1e4aeb5))


### Bug Fixes

* **basic_types:** bincode deserialization for `web3::Bytes`
([#1928](#1928))
([406ec8c](406ec8c))
* **config:** Fix data-handler-config
([#1919](#1919))
([b6bb041](b6bb041))
* **en:** Delete old txs by (init_addr, nonce)
([#1942](#1942))
([fa5f4a7](fa5f4a7))
* **en:** Fix reorg detector logic for dealing with last L1 batch
([#1906](#1906))
([3af5f5b](3af5f5b))
* parentHash in websocket blocks subscription is shown as 0x0
([#1946](#1946))
([fc2efad](fc2efad))
* **Prover CLI:** `status batch` bugs
([#1865](#1865))
([09682f2](09682f2))
* **utils:** bincode ser-/deserialization for `BytesToHexSerde`
([#1947](#1947))
([a75b917](a75b917))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
RomanBrodetski pushed a commit that referenced this pull request May 17, 2024
🤖 I have created a release *beep* *boop*
---


##
[14.2.0](prover-v14.1.1...prover-v14.2.0)
(2024-05-17)


### Features

* Added support for making EN a (non-leader) consensus validator
(BFT-426)
([#1905](#1905))
([9973629](9973629))
* **configs:** Extract secrets to an additional config
([#1956](#1956))
([bab4d65](bab4d65))
* **eth-client:** Generalize RPC client
([#1898](#1898))
([a4e099f](a4e099f))
* **Prover CLI:** `delete` cmd
([#1802](#1802))
([6e4a92e](6e4a92e))
* **Prover CLI:** `requeue` cmd
([#1719](#1719))
([f722df7](f722df7))
* **Prover CLI:** `status batch --verbose`
([#1899](#1899))
([cf80184](cf80184))
* **state-keeper:** Parallel l2 block sealing
([#1801](#1801))
([9b06dd8](9b06dd8))
* tee_verifier_input_producer
([#1860](#1860))
([fea7f16](fea7f16))


### Bug Fixes

* **Prover CLI:** `status batch` bugs
([#1865](#1865))
([09682f2](09682f2))
* **prover:** Bump Cargo.lock and update VKs
([#1959](#1959))
([367baad](367baad))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants